This repository was archived by the owner on Dec 6, 2024. It is now read-only.
use bucketName instead of bucketName and bucketInstanceName #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
wlan0
commented
Mar 26, 2021
| // +optional | ||
| BucketRequestName string `json:"bucketRequestName,omitempty"` | ||
| // +optional | ||
| BucketName string `json:"bucketName,omitempty"` |
There was a problem hiding this comment.
this is for the brownfield usecase
jeffvance
reviewed
Mar 26, 2021
| @@ -118,7 +118,7 @@ type BucketRequest struct { | |||
|
|
|||
| type BucketRequestSpec struct { | |||
| // +optional | |||
| BucketInstanceName string `json:"bucketInstanceName,omitempty"` | |||
| BucketName string `json:"bucketName,omitempty"` | |||
There was a problem hiding this comment.
this field is no longer in BR.spec (per latest kep pr). Instead, following api guidance, bucketName is now defined in BR.status.
jeffvance
reviewed
Mar 26, 2021
| type: string | ||
| bucketRequestName: | ||
| type: string | ||
| serviceAccountName: | ||
| type: string | ||
| required: | ||
| - bucketAccessClassName | ||
| - bucketRequestName |
There was a problem hiding this comment.
- BR-name is still needed in BAR.spec to handle sharing w/in the same namespace. (If I'm understanding this change correctly).
bucketNameneeds to be in BAR.spec (per latest kep pr).- 1 & 2 are mutually exclusive.
There was a problem hiding this comment.
In this line, it is only being removed from the REQUIRED list. Since it is either or with bucketName
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Mar 26, 2021
- Requires changes to API from this PR kubernetes-retired/container-object-storage-interface-api#35 - Requires changes to SPEC from this PR kubernetes-retired/container-object-storage-interface-spec#25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Mar 26, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Mar 26, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Mar 26, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
removed
the
lgtm
wlan0
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Mar 31, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Mar 31, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Mar 31, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Mar 31, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Apr 5, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Apr 5, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Apr 6, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
wlan0
added a commit
to wlan0/container-object-storage-interface-provisioner-sidecar
that referenced
this pull request
Apr 6, 2021
- Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-api/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Jun 6, 2024
- Requires changes to API from this PR github.com/kubernetes-retired/pull/35 - Requires changes to API from this PR github.com/kubernetes-retired/container-object-storage-interface-spec/pull/25
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
Jun 14, 2024
README: Fix document link
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous design had the two values be different, now that the backend bucket name and the name of the bucket object are the same, it doesn't make sense to have two different field names for the same value. @bswartz